linux-kernel - Re: crypto: ux500 - memmove the right size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c579737-b46b-dc6a-102c-5b6931d4224a@gmx.de>
Date:	Mon, 11 Jul 2016 16:40:34 +0200
From:	Toralf Förster <toralf.foerster@....de>
To:	David Binderman <linuxdev.baldrick@...il.com>
Cc:	Joakim Bech <joakim.bech@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: crypto: ux500 - memmove the right size

While reading the comment to 19ced623d :

"    The hash buffer is really HASH_BLOCK_SIZE bytes, someone
    must have thought that memmove takes n*u32 words by mistake.
    Tests work as good/bad as before after this patch.
"

I was just curious why the tests doesn't fail now and since when the bug were in the code.
The answer to the later is simple - the bug is there since the beginning of that file.
What's do you think about the first question ?

-- 
Toralf
PGP: C4EACDDE 0076E94E, OTR: 420E74C8 30246EE7