linux-kernel - Re: crypto: ux500 - memmove the right size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160712045714.GB27925@gondor.apana.org.au>
Date:	Tue, 12 Jul 2016 12:57:14 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Toralf Förster <toralf.foerster@....de>
Cc:	David Binderman <linuxdev.baldrick@...il.com>,
	Joakim Bech <joakim.bech@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: crypto: ux500 - memmove the right size

On Mon, Jul 11, 2016 at 04:40:34PM +0200, Toralf Förster wrote:
> While reading the comment to 19ced623d :
> 
> "    The hash buffer is really HASH_BLOCK_SIZE bytes, someone
>     must have thought that memmove takes n*u32 words by mistake.
>     Tests work as good/bad as before after this patch.
> "
> 
> I was just curious why the tests doesn't fail now and since when the bug were in the code.
> The answer to the later is simple - the bug is there since the beginning of that file.
> What's do you think about the first question ?

The tests do/can not cover every possible execution path.  Of course
if you can write a simple vector/test that covers this case that
would be very nice.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt