linux-kernel - Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712071938.GD4663@mail.corp.redhat.com>
Date:	Tue, 12 Jul 2016 09:19:39 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jiri Kosina <jikos@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Yusuke Fujimaki <usk.fujimaki@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY

On Jul 11 2016 or thereabouts, Arnd Bergmann wrote:
> A recent commit added barry support to this driver, but that causes
> a link failure when CONFIG_POWER_SUPPLY is not set:
> 
> drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> drivers/hid/built-in.o: In function `hidpp_raw_event':
> :(.text+0x1b10c): undefined reference to `power_supply_changed'
> drivers/hid/built-in.o: In function `hidpp_connect_event':
> :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> :(.text+0x1be30): undefined reference to `power_supply_powers'
> 
> This adds a dependency, identically to the other HID drivers that need this.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")

Thanks for the fix.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

> ---
>  drivers/hid/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 78ac4811bd3c..4c6b59c9fa15 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
>  config HID_LOGITECH_HIDPP
>  	tristate "Logitech HID++ devices support"
>  	depends on HID_LOGITECH
> +	select POWER_SUPPLY
>  	---help---
>  	Support for Logitech devices relyingon the HID++ Logitech specification
>  
> -- 
> 2.9.0
>