linux-kernel - Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jul 2016 11:18:20 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:	Arnd Bergmann <arnd@...db.de>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Yusuke Fujimaki <usk.fujimaki@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY

On Tue, 12 Jul 2016, Benjamin Tissoires wrote:

> > A recent commit added barry support to this driver, but that causes
> > a link failure when CONFIG_POWER_SUPPLY is not set:
> > 
> > drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> > :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> > drivers/hid/built-in.o: In function `hidpp_raw_event':
> > :(.text+0x1b10c): undefined reference to `power_supply_changed'
> > drivers/hid/built-in.o: In function `hidpp_connect_event':
> > :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> > :(.text+0x1be30): undefined reference to `power_supply_powers'
> > 
> > This adds a dependency, identically to the other HID drivers that need this.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
> 
> Thanks for the fix.
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Thanks. I am pushing this to for-4.8/logitech-hidpp-battery, but I will be 
unmerging that branch from 'for-next' shortly anyway, as the whole 
patchset is currently on hold.

-- 
Jiri Kosina
SUSE Labs