[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3ced7a51-bca9-5814-080c-350ca320a036@cogentembedded.com>
Date: Tue, 12 Jul 2016 14:16:29 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Colin Ian King <colin.king@...onical.com>,
"David S . Miller" <davem@...emloft.net>, linux-ide@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ide: hpt366: fix incorrect mask when checking at
cmd_high_time
On 7/12/2016 2:10 PM, Colin Ian King wrote:
>>>> From: Colin Ian King <colin.king@...onical.com>
>>>>
>>>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
>>>> bits 11:8 specify the primary drive cmd_high_time, however,
>>>> currently just 3 bits of the 4 are being used because the mask
>>>> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
>>>> to be detected.
>>>>
>>>> Also add in missing space between switch and parenthesis to clean
>>>> up a checkpatch warning.
>>>>
>>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>>
>>> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>
>> BTW, drivers/ata/pata_hpt366.c has the same bug...
>
> OK, I'll fix that too in a moment.
TIA! Don't forget to increment the version though. :-)
MBR, Sergei
Powered by blists - more mailing lists