linux-kernel - Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160726.152617.309548003660454771.davem@davemloft.net>
Date:	Tue, 26 Jul 2016 15:26:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	colin.king@...onical.com
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ide: hpt366: fix incorrect mask when checking at
 cmd_high_time

From: Colin King <colin.king@...onical.com>
Date: Tue, 12 Jul 2016 11:59:39 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x07 and not 0x0f.  Fix the mask, allowing for the 40MHz clock
> to be detected.
> 
> Also add in missing space between switch and parenthesis to clean
> up a checkpatch warning.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.