linux-kernel - Re: [PATCH 2/7] gpu: drm: sti_compositor: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+M3ks7Q4CJ3OskRoEXZM9SY7dMMxMotkdGP_w=n=67NGnGwLA@mail.gmail.com>
Date:	Tue, 12 Jul 2016 14:59:23 +0200
From:	Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:	Peter Chen <peter.chen@....com>
Cc:	David Airlie <airlied@...ux.ie>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Vincent Abriou <vincent.abriou@...com>
Subject: Re: [PATCH 2/7] gpu: drm: sti_compositor: add missing of_node_put
 after calling of_parse_phandle

Acked-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@....com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> Cc: Vincent Abriou <vincent.abriou@...com>
> Signed-off-by: Peter Chen <peter.chen@....com>
> ---
>  drivers/gpu/drm/sti/sti_compositor.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c
> index 3d2fa3a..064de14 100644
> --- a/drivers/gpu/drm/sti/sti_compositor.c
> +++ b/drivers/gpu/drm/sti/sti_compositor.c
> @@ -247,10 +247,12 @@ static int sti_compositor_probe(struct platform_device *pdev)
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0);
>         if (vtg_np)
>                 compo->vtg_main = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 1);
>         if (vtg_np)
>                 compo->vtg_aux = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         platform_set_drvdata(pdev, compo);
>
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog