linux-kernel - Re: [PATCH 3/7] gpu: drm: sti_vdo: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+M3ks6xh5fs7HJN5=sTMbdw0Z0Q9uYH4dc3uEF8i+++4k7=cA@mail.gmail.com>
Date:	Tue, 12 Jul 2016 14:59:35 +0200
From:	Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:	Peter Chen <peter.chen@....com>
Cc:	David Airlie <airlied@...ux.ie>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Vincent Abriou <vincent.abriou@...com>
Subject: Re: [PATCH 3/7] gpu: drm: sti_vdo: add missing of_node_put after
 calling of_parse_phandle

Acked-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@....com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> Cc: Vincent Abriou <vincent.abriou@...com>
> Signed-off-by: Peter Chen <peter.chen@....com>
> ---
>  drivers/gpu/drm/sti/sti_dvo.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
> index 25f7663..7e211a8 100644
> --- a/drivers/gpu/drm/sti/sti_dvo.c
> +++ b/drivers/gpu/drm/sti/sti_dvo.c
> @@ -602,6 +602,7 @@ static int sti_dvo_probe(struct platform_device *pdev)
>         dvo->panel_node = of_parse_phandle(np, "sti,panel", 0);
>         if (!dvo->panel_node)
>                 DRM_ERROR("No panel associated to the dvo output\n");
> +       of_node_put(dvo->panel_node);
>
>         platform_set_drvdata(pdev, dvo);
>
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog