linux-kernel - Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578501E9.6090008@osg.samsung.com>
Date:	Tue, 12 Jul 2016 08:42:49 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Joe Perches <joe@...ches.com>, kyungmin.park@...sung.com,
	k.debski@...sung.com, jtp.park@...sung.com, mchehab@...nel.org,
	javier@....samsung.com
Cc:	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] media: s5p-mfc Fix misspelled error message and
 checkpatch errors

On 07/12/2016 08:06 AM, Joe Perches wrote:
> On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
>> Fix misspelled error message and existing checkpatch errors in the
>> error message conditional.
> []
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> []
>> @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv,
>>  	u32 left, right, top, bottom;
>>  
>>  	if (ctx->state != MFCINST_HEAD_PARSED &&
>> -	ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
>> -					&& ctx->state != MFCINST_FINISHED) {
>> -			mfc_err("Cannont set crop\n");
>> -			return -EINVAL;
>> -		}
>> +	    ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
>> +	    && ctx->state != MFCINST_FINISHED) {
>> +		mfc_err("Can not get crop information\n");
>> +		return -EINVAL;
>> +	}
> 
> is it a set or a get?

vidioc_g_crop is a get routine.

> 
> It'd be nicer for humans to read if the alignment was consistent

Are you okay with this alignment change or would you like it
changed? checkpatch stopped complaining with the code as follows:

> 
> 	if (ctx->state != MFCINST_HEAD_PARSED &&
> 	    ctx->state != MFCINST_RUNNING &&
> 	    ctx->state != MFCINST_FINISHING &&
> 	    ctx->state != MFCINST_FINISHED) {
> 		mfc_err("Can not get crop information\n");
> 		return -EINVAL;
> 	}
> 
> 

thanks,
-- Shuah