linux-kernel - Re: Severe performance regression w/ 4.4+ on Android due to cgroup locking changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160713205433.GD29670@mtj.duckdns.org>
Date:	Wed, 13 Jul 2016 16:54:33 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Colin Cross <ccross@...gle.com>
Cc:	John Stultz <john.stultz@...aro.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Dmitry Shmidt <dimitrysh@...gle.com>,
	Rom Lemarchand <romlem@...gle.com>,
	Todd Kjos <tkjos@...gle.com>, Oleg Nesterov <oleg@...hat.com>
Subject: Re: Severe performance regression w/ 4.4+ on Android due to cgroup
 locking changes

Hello,

On Wed, Jul 13, 2016 at 01:44:50PM -0700, Colin Cross wrote:
> > Switching between foreground and background isn't a hot path.  It's
> > human initiated operations after all.  It taking 80 msecs sure is
> > problematic but I'm skeptical that this is from actual contention
> > given that the only reader side holders are fork and exit paths.
> 
> Slight correction here, we move tasks to the foreground cgroup and
> back around binder IPC calls from foreground processes to background
> processes, so it is significantly hotter than just human initiated
> operations.

Oh I see.  That's extreme and you would be paying in terms of
migration overhead.  It really doesn't make sense to generally
optimize for migration as that often translates directly to overhead
in actual hot paths in various controllers.  That said, I don't think
it'd be too difficult to keep things acceptable for the android case.

Thanks.

-- 
tejun