linux-kernel - Re: [GIT PULL 00/66] perf/core improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160713205449.GA30909@twins.programming.kicks-ass.net>
Date:	Wed, 13 Jul 2016 22:54:49 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Chris Phlipot <cphlipot0@...il.com>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	David Ahern <dsahern@...il.com>,
	Davidlohr Bueso <dbueso@...e.de>,
	David Tolnay <dtolnay@...il.com>,
	Eric Auger <eric.auger@...aro.org>,
	Hemant Kumar <hemant@...ux.vnet.ibm.com>,
	Hitoshi Mitake <mitake@....info.waseda.ac.jp>,
	Jiri Olsa <jolsa@...nel.org>,
	Marc Zyngier <marc.zyngier@....com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	"Naveen N . Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Vineet Gupta <vgupta@...opsys.com>,
	Wang Nan <wangnan0@...wei.com>,
	Yunlong Song <yunlong.song@...wei.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [GIT PULL 00/66] perf/core improvements and fixes

On Wed, Jul 13, 2016 at 03:49:14PM -0500, Josh Poimboeuf wrote:
> That '#define BITS_PER_LONG 32' comes from the following code in
> tools/include/asm-generic/bitsperlong.h:
> 
>   #ifdef CONFIG_64BIT
>   #define BITS_PER_LONG 64
>   #else
>   #define BITS_PER_LONG 32
>   #endif /* CONFIG_64BIT */
> 
> Because objtool doesn't have CONFIG_64BIT defined, it falls through to
> the '#else' condition.  I think tools code shouldn't be relying on
> kernel config options.

Right.. __LP64__ would work in general I think, or __SIZEOF_LONG__ *
__CHAR_BIT__.