linux-kernel - Re: [GIT PULL 00/66] perf/core improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160713204914.zs77db76wuvharn6@treble>
Date:	Wed, 13 Jul 2016 15:49:14 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Chris Phlipot <cphlipot0@...il.com>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	David Ahern <dsahern@...il.com>,
	Davidlohr Bueso <dbueso@...e.de>,
	David Tolnay <dtolnay@...il.com>,
	Eric Auger <eric.auger@...aro.org>,
	Hemant Kumar <hemant@...ux.vnet.ibm.com>,
	Hitoshi Mitake <mitake@....info.waseda.ac.jp>,
	Jiri Olsa <jolsa@...nel.org>,
	Marc Zyngier <marc.zyngier@....com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	"Naveen N . Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Peter Zijlstra <peterz@...radead.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Vineet Gupta <vgupta@...opsys.com>,
	Wang Nan <wangnan0@...wei.com>,
	Yunlong Song <yunlong.song@...wei.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [GIT PULL 00/66] perf/core improvements and fixes

On Wed, Jul 13, 2016 at 09:35:27AM +0200, Ingo Molnar wrote:
> 
> Hm, the objtool build broke:
> 
>   GEN      arch/x86/insn/inat-tables.c
>   CC       arch/x86/decode.o
> In file included from /home/mingo/tip/tools/include/linux/hashtable.h:12:0,
>                  from arch/x86/../../elf.h:24,
>                  from arch/x86/decode.c:26:
> /home/mingo/tip/tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" 
> redefined [-Werror]
>  #define BITS_PER_LONG __WORDSIZE
>  ^
> In file included from /usr/include/x86_64-linux-gnu/asm/bitsperlong.h:10:0,
>                  from /usr/include/asm-generic/int-ll64.h:11,
>                  from /usr/include/asm-generic/types.h:6,
>                  from /usr/include/x86_64-linux-gnu/asm/types.h:4,
>                  from /home/mingo/tip/tools/include/linux/types.h:9,
>                  from /home/mingo/tip/tools/include/linux/list.h:4,
>                  from arch/x86/../../elf.h:23,
>                  from arch/x86/decode.c:26:
> /home/mingo/tip/tools/include/asm-generic/bitsperlong.h:10:0: note: this is the 
> location of the previous definition
>  #define BITS_PER_LONG 32
>  ^

Hi Ingo,

There's still another issue.  Notice in the last line there that
BITS_PER_LONG is getting incorrectly set to 32, at least for objtool.

That '#define BITS_PER_LONG 32' comes from the following code in
tools/include/asm-generic/bitsperlong.h:

  #ifdef CONFIG_64BIT
  #define BITS_PER_LONG 64
  #else
  #define BITS_PER_LONG 32
  #endif /* CONFIG_64BIT */

Because objtool doesn't have CONFIG_64BIT defined, it falls through to
the '#else' condition.  I think tools code shouldn't be relying on
kernel config options.

-- 
Josh