linux-kernel - Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715191515.GC13516@tuxbot>
Date:	Fri, 15 Jul 2016 12:15:15 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	njaigane@...eaurora.org
Cc:	linux-arm-msm@...r.kernel.org, linux@....qualcomm.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	twp@...eaurora.org, andy.gross@...aro.org, david.brown@...aro.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@...linux.org.uk, mturquette@...libre.com,
	sboyd@...eaurora.org, linus.walleij@...aro.org,
	plai@...eaurora.org, bgoswami@...eaurora.org, lgirdwood@...il.com,
	broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
	varada@...eaurora.org, pradeepb@...eaurora.org,
	snlakshm@...eaurora.org, linux-clk@...r.kernel.org,
	linux-gpio@...r.kernel.org, alsa-devel@...a-project.org,
	bselvara@...eaurora.org
Subject: Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support

On Fri 15 Jul 00:07 PDT 2016, njaigane@...eaurora.org wrote:

> From: Jaiganesh Narayanan <njaigane@...eaurora.org>
> 
> This patch adds the tlmm/pinctrl support for IPQ4019 ASoC.
> 
> Signed-off-by: Jaiganesh Narayanan <njaigane@...eaurora.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-ipq4019.c | 116 +++++++++++++++++++++++++--------
>  1 file changed, 88 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
[..]
> +	qca_mux_i2s_rx_mclk,
> +	qca_mux_i2s_rx_bclk,
> +	qca_mux_i2s_rx_fsync,
> +	qca_mux_i2s_rxd,
> +	qca_mux_i2s_tx_mclk,
> +	qca_mux_i2s_tx_bclk,
> +	qca_mux_i2s_tx_fsync,
> +	qca_mux_i2s_txd1,
> +	qca_mux_i2s_txd2,
> +	qca_mux_i2s_txd3,
> +	qca_mux_i2s_spdif_out,
> +	qca_mux_i2s_spdif_in,

I would recommend reducing this to "i2s_rx", "i2s_tx", "spdif_rx"
and "spdif_tx", as this will make the dts cleaner.

Regards,
Bjorn