linux-kernel - Re: [PATCH] usb: ohci-platform: use helper variables in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1607151551490.26524-100000@netrider.rowland.org>
Date:	Fri, 15 Jul 2016 15:52:15 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Rafał Miłecki <zajec5@...il.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:USB OHCI DRIVER" <linux-usb@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: ohci-platform: use helper variables in probe function

On Fri, 15 Jul 2016, Rafał Miłecki wrote:

> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> 
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>

Acked-by: Alan Stern <stern@...land.harvard.edu>