linux-kernel - Re: [PATCH] usb: ohci-platform: use helper variables in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 15:59:11 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	"open list:USB OHCI DRIVER" <linux-usb@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: ohci-platform: use helper variables in probe
 function

On Fri, Jul 15, 2016 at 07:18:50AM +0200, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> 
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> Acked-by: Alan Stern <stern@...land.harvard.edu>
> ---
>  drivers/usb/host/ohci-platform.c | 66 +++++++++++++++++++---------------------
>  1 file changed, 32 insertions(+), 34 deletions(-)

While "nice" this really isn't needed, unless you are going to do
something after this patch is applied.  And if so, please submit it as a
patch series.  As it is, it just looks like unneeded churn, sorry, so
I'm not going to take it.

thanks,

greg k-h