linux-kernel - Re: [PATCH v3 2/8] thunderbolt: Updating device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160715.145345.1714630247405044715.davem@davemloft.net>
Date:	Fri, 15 Jul 2016 14:53:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amir.jer.levy@...el.com
Cc:	andreas.noever@...il.com, gregkh@...uxfoundation.org,
	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	thunderbolt-linux@...el.com, mika.westerberg@...el.com,
	tomas.winkler@...el.com
Subject: Re: [PATCH v3 2/8] thunderbolt: Updating device IDs

From: "Levy, Amir (Jer)" <amir.jer.levy@...el.com>
Date: Fri, 15 Jul 2016 18:56:39 +0000

> On Fri, Jul 15 2016, 09:49 PM, David Miller wrote:
>> From: Amir Levy <amir.jer.levy@...el.com>
>> Date: Thu, 14 Jul 2016 14:28:16 +0300
>> 
>> > Adding the new Thunderbolt(TM) device IDs to the list.
>> >
>> > Signed-off-by: Amir Levy <amir.jer.levy@...el.com>
>> 
>> Unless these PCI-IDs, all of them, are going to be used in multiple spots in the
>> kernel, it is not appropriate to add them here.
>> 
>> They belong as private macros in the drivers themselves, instead.
> 
> They might be used: http://www.spinics.net/lists/linux-pci/msg51331.html

Then move them to the common location when this "might" thing actually
happens.