linux-kernel - Re: [PATCH] clk: probe common clock drivers earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyi1M72bMn8xKz-btG6BxuSyfY+8FR6gu3Fd5jy7RhbFg@mail.gmail.com>
Date:	Sat, 16 Jul 2016 06:53:56 +0900
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-clk@...r.kernel.org,
	Jay Sternberg <jay.e.sternberg@...el.com>,
	Jens Axboe <axboe@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Matias Bjørling <m@...rling.me>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Valentin Rothberg <valentinrothberg@...il.com>
Subject: Re: [PATCH] clk: probe common clock drivers earlier

This is still in my "what happened to this" patch list..

I'm dropping it as I'll be without internet for a week and I'm trying
to make sure my pile is empty, but I'd like somebody to take a look at
it (Greg?) since it feels right to me.

             Linus

On Thu, May 5, 2016 at 4:57 PM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE().  Clocks should come earlier because they are
> prerequisites for many of other drivers.  It will help to mitigate
> EPROBE_DEFER issues.
>
> Also, drop the comment since it does not look valuable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  drivers/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..a2a4922 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -44,6 +44,7 @@ obj-$(CONFIG_REGULATOR)               += regulator/
>
>  # reset controllers early, since gpu drivers might rely on them to initialize
>  obj-$(CONFIG_RESET_CONTROLLER) += reset/
> +obj-y                          += clk/
>
>  # tty/ comes before char/ so that the VT console is the boot-time
>  # default.
> @@ -141,8 +142,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
>  obj-$(CONFIG_VLYNQ)            += vlynq/
>  obj-$(CONFIG_STAGING)          += staging/
>  obj-y                          += platform/
> -#common clk code
> -obj-y                          += clk/
>
>  obj-$(CONFIG_MAILBOX)          += mailbox/
>  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> --
> 1.9.1
>