linux-kernel - Re: [PATCH 2/2] [media] cec: add RC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578DE51E.8080604@xs4all.nl>
Date:	Tue, 19 Jul 2016 10:30:22 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Arnd Bergmann <arnd@...db.de>,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:	Hans Verkuil <hans.verkuil@...co.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kamil Debski <kamil@...as.org>, linux-media@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] [media] cec: add RC_CORE dependency

On 07/19/16 10:10, Arnd Bergmann wrote:
> We cannot build the cec driver when the RC core is a module
> and cec is built-in:
> 
> drivers/staging/built-in.o: In function `cec_allocate_adapter':
> :(.text+0x134): undefined reference to `rc_allocate_device'
> drivers/staging/built-in.o: In function `cec_register_adapter':
> :(.text+0x304): undefined reference to `rc_register_device'
> 
> This adds an explicit dependency to avoid this case. We still
> allow building when CONFIG_RC_CORE is disabled completely,
> as the driver has checks for this case itself.

This makes no sense: the rc_allocate_device and rc_register_device
are under:

#if IS_REACHABLE(CONFIG_RC_CORE)

So it shouldn't be enabled at all, should it?

Regards,

	Hans

> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I originally submitted this on June 29, but it may have gotten
> lost as out of the three patch series, one patch got replaced
> and another patch got applied, but nothing happened on this one.
> ---
>  drivers/staging/media/cec/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig
> index 21457a1f6c9f..c623bd32a5b8 100644
> --- a/drivers/staging/media/cec/Kconfig
> +++ b/drivers/staging/media/cec/Kconfig
> @@ -1,6 +1,7 @@
>  config MEDIA_CEC
>  	bool "CEC API (EXPERIMENTAL)"
>  	depends on MEDIA_SUPPORT
> +	depends on RC_CORE || !RC_CORE
>  	select MEDIA_CEC_EDID
>  	---help---
>  	  Enable the CEC API.
>