linux-kernel - Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function call "mempool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1607191228070.52203@chino.kir.corp.google.com>
Date:	Tue, 19 Jul 2016 12:28:48 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function
 call "mempool_destroy"

On Tue, 19 Jul 2016, SF Markus Elfring wrote:

> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Mon, 16 Nov 2015 08:20:36 +0100
> > 
> > The mempool_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the calls is not needed.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > ---
> >  arch/sh/kernel/dwarf.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c
> > index 9d209a0..e1d751a 100644
> > --- a/arch/sh/kernel/dwarf.c
> > +++ b/arch/sh/kernel/dwarf.c
> > @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void)
> >  	rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node)
> >  		kfree(cie);
> >  
> > -	if (dwarf_reg_pool)
> > -		mempool_destroy(dwarf_reg_pool);
> > -	if (dwarf_frame_pool)
> > -		mempool_destroy(dwarf_frame_pool);
> > +	mempool_destroy(dwarf_reg_pool);
> > +	mempool_destroy(dwarf_frame_pool);
> >  	kmem_cache_destroy(dwarf_reg_cachep);
> >  	kmem_cache_destroy(dwarf_frame_cachep);
> >  }
> > 
> 
> How do you think about to integrate this update suggestion
> into another source code repository?
> 

Your patch is fine, but you may want to send it to the maintainers 
directly to merge.

$ ./scripts/get_maintainer.pl -f arch/sh/kernel/dwarf.c
Yoshinori Sato <ysato@...rs.sourceforge.jp> (maintainer:SUPERH)
Rich Felker <dalias@...c.org> (maintainer:SUPERH)
linux-sh@...r.kernel.org (open list:SUPERH)
linux-kernel@...r.kernel.org (open list)