linux-kernel - Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH76GKM1Ls0aHaT7SZch6y7xz+ywY_9RyzR55PnXXEsdGvnUxA@mail.gmail.com>
Date:	Thu, 21 Jul 2016 15:52:29 +0200
From:	Grzegorz Jaszczyk <jaz@...ihalf.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Russell King - ARM Linux <linux@...linux.org.uk>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	mark.rutland@....com, Jason Cooper <jason@...edaemon.net>,
	andrew@...n.ch,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Marcin Wojtas <mw@...ihalf.com>,
	Lior Amsalem <alior@...vell.com>
Subject: Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

Hi Russel, Thmoas

2016-07-21 14:46 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@...e-electrons.com>:
> Hello,
>
> On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
>> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
>> > Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
>>
>> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
>> Should we build-in all PCIe drivers?
>
> I agree.
>
>> I think it makes more sense to have this as a module rather than built-in.
>
> I would prefer to not have it all in the defconfig. I'd hate to have
> a defconfig that builds tons of random modules "just because".

Both Semihalf and Marvel ISL teams use E1000E NICs with Marvell boards
for development/testing purpose, so we always have to enable it
manually - that's the reason why I wanted to have it enabled by
default.
Nevertheless it is indeed not part of the SoC and I understand your
arguments. I will drop it in the next patch-set version

Thank you,
Grzegorz