linux-kernel - Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721221605.GA21883@rob-hp-laptop>
Date:	Thu, 21 Jul 2016 17:16:05 -0500
From:	Rob Herring <robh@...nel.org>
To:	Grzegorz Jaszczyk <jaz@...ihalf.com>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, mark.rutland@....com,
	jason@...edaemon.net, andrew@...n.ch,
	sebastian.hesselbarth@...il.com, linux@...linux.org.uk,
	thomas.petazzoni@...e-electrons.com,
	gregory.clement@...e-electrons.com, mw@...ihalf.com,
	alior@...vell.com
Subject: Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC
 family

On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
> Beside interfaces described in the armada-39x.dtsi, the Armada 395 SoC
> family supports: 2 x SATA3 (2 ports in one unit) and the USB3.0
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
> ---
>  .../devicetree/bindings/arm/marvell/armada-39x.txt |  2 +-
>  arch/arm/boot/dts/armada-395.dtsi                  | 76 ++++++++++++++++++++++
>  2 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/armada-395.dtsi
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> index 53d4ff9..f066801 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> @@ -17,4 +17,4 @@ compatible: must contain "marvell,armada398"
>  
>  Example:
>  
> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";

If 395 came after 398, then it should come first in the order. This 
implies that marvell,armada398 is a better match than marvell,armada395. 
Or perhaps you shouldn't have both?

Rob