linux-kernel - Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c604e92f-9bcd-da2c-8d78-2a678c81b05f@cogentembedded.com>
Date:	Thu, 21 Jul 2016 21:45:59 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	tom.ty89@...il.com, tj@...nel.org, hare@...e.de, arnd@...db.de
Cc:	sfr@...b.auug.org.au, linux-ide@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

Hello.

On 07/21/2016 09:41 PM, tom.ty89@...il.com wrote:

> From: Tom Yan <tom.ty89@...il.com>
>
> 1. Removed a repeated bit masking in ata_mselect_control()
> 2. Moved `wce`/`d_sense` assignment below the page validity checks
> 3. Added/Removed empty lines where appropriate
>
> Signed-off-by: Tom Yan <tom.ty89@...il.com>

    Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch is 
a better practice.

[...]

MBR, Sergei