linux-kernel - Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5791BEF3.5060404@samsung.com>
Date:	Fri, 22 Jul 2016 08:36:35 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Rob Herring <robh@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Richard Purdie <rpurdie@...ys.net>, drivshin.allworx@...il.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org, kernel@...a-handheld.com,
	marek@...delico.com, letux-kernel@...nphoenux.org,
	Andrey Utkin <andrey_utkin@...tmail.com>
Subject: Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver

On 07/20/2016 03:24 AM, Rob Herring wrote:
> On Tue, Jul 19, 2016 at 01:47:31PM +0200, H. Nikolaus Schaller wrote:
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> ---
>>   .../devicetree/bindings/leds/is31fl319x.txt        | 59 ++++++++++++++++++++++
>>   1 file changed, 59 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt
>> new file mode 100644
>> index 0000000..03287c0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt
>> @@ -0,0 +1,59 @@
>> +LEDs connected to is31fl319x LED controller chip
>> +
>> +Required properties:
>> +- compatible : Should be any of
>> +	"issi,is31fl3190"
>> +	"issi,is31fl3191"
>> +	"issi,is31fl3193"
>> +	"issi,is31fl3196"
>> +	"issi,is31fl3199"
>> +	"si-en,sn3199".
>> +- #address-cells: Must be 1.
>> +- #size-cells: Must be 0.
>> +- reg: 0x64, 0x65, 0x66, 0x67.
>
> This is an OR or AND? OR it seems. With that,

Nikolaus, could you please make it explicit?

>
> Acked-by: Rob Herring <robh@...nel.org>
>
>


-- 
Best regards,
Jacek Anaszewski