linux-kernel - Re: [PATCH] add u64 number parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e325cbb-a140-8f26-7402-5dc1a2cd07ea@sandisk.com>
Date:	Fri, 22 Jul 2016 18:32:23 -0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	James Smart <james.smart@...adcom.com>,
	<linux-kernel@...r.kernel.org>, <linux-nvme@...ts.infradead.org>,
	<linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] add u64 number parser

On 07/22/16 17:23, James Smart wrote:
> +	buf = kmalloc(len + 1, GFP_KERNEL);
> +	if (!buf)
> +		return -ENOMEM;
> +	memcpy(buf, s->from, len);
> +	buf[len] = '\0';

Hello James,

Have you considered to combine the above kmalloc() and memcpy() calls 
into a single kasprintf(GFP_KERNEL, "%.*s", len, s->from) call?

Bart.