linux-kernel - Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B9BE2409-56EE-4521-9723-4A3BE2EFC511@alibaba-inc.com>
Date:	Sat, 23 Jul 2016 09:58:55 +0800
From:	Minfei Huang <minfei.hmf@...baba-inc.com>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	mst@...hat.com, virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, fanc.fnst@...fujitsu.com,
	Minfei Huang <mnghuan@...il.com>
Subject: Re: [PATCH v3] virtio_blk: Fix a slient kernel panic


Ping, Any comment is appreciate.

Thanks
Minfei

> On Jul 19, 2016, at 20:22, Cornelia Huck <cornelia.huck@...ibm.com> wrote:
> 
> On Tue, 19 Jul 2016 12:32:42 +0800
> Minfei Huang <mnfhuang@...il.com> wrote:
> 
>> From: Minfei Huang <mnghuan@...il.com>
>> 
>> We do a lot of memory allocation in function init_vq, and don't handle
>> the allocation failure properly. Then this function will return 0,
>> although initialization fails due to lacking memory. At that moment,
>> kernel will panic in guest machine, if virtio is used to drive disk.
>> 
>> To fix this bug, we should take care of allocation failure, and return
>> correct value to let caller know what happen.
>> 
>> Tested-by: Chao Fan <fanc.fnst@...fujitsu.com>
>> Signed-off-by: Minfei Huang <minfei.hmf@...baba-inc.com>
>> Signed-off-by: Minfei Huang <mnghuan@...il.com>
>> ---
>> v2:
>> - Remove useless initialisation to NULL
>> v1:
>> - Refactor the patch to make code more readable
>> ---
>> drivers/block/virtio_blk.c | 26 ++++++++------------------
>> 1 file changed, 8 insertions(+), 18 deletions(-)
> 
> Your changes certainly make the function more compact.
> 
> Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>


Download attachment "smime.p7s" of type "application/pkcs7-signature" (2353 bytes)