linux-kernel - Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57966931.4020505@bfs.de>
Date:	Mon, 25 Jul 2016 21:32:01 +0200
From:	walter harms <wharms@....de>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
CC:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables
 in mac_ioctl()



Am 25.07.2016 21:17, schrieb Lino Sanfilippo:
>>  
>> -			if (strncasecmp(buff, "RSSI", length) == 0) {
>> +			if (strncasecmp(buff, "RSSI", 0) == 0) {
>> +				s8 rssi;
>> +
> 
> Um, please think a second about if it makes any sense at all to compare 
> zero chars of two strings.
> 
> Lino

also:
the switch has only one case and default.

re,
 wh