linux-kernel - Re: staging: wilc1000: Reduce scope for a few variables in mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8d9729c-6d65-a901-1b29-c0b031e143d2@users.sourceforge.net>
Date:	Tue, 26 Jul 2016 08:25:54 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org, linux-wireless@...r.kernel.org,
	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Steve Caldwell <Steve.Caldwell@...rochip.com>
Subject: Re: staging: wilc1000: Reduce scope for a few variables in
 mac_ioctl()

>> -			if (strncasecmp(buff, "RSSI", length) == 0) {
>> +			if (strncasecmp(buff, "RSSI", 0) == 0) {
>> +				s8 rssi;
>> +
> 
> Um, please think a second about if it makes any sense at all to compare 
> zero chars of two strings.

Under which circumstances should the variable "length" contain an other
value than zero?

How can this open issue be fixed better?

Regards,
Markus