linux-kernel - Re: [PATCH RESEND] floppy: fix open(O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c713fa8-9da1-47b5-0d5d-92f4cd13493a@kernel.dk>
Date:	Mon, 25 Jul 2016 14:48:54 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	Wim Osterholt <wim@....tudelft.nl>
Subject: Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On 06/30/2016 05:18 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
>
> Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
> side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
> this is being used setfdprm userspace for ioctl-only open().
>
> Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
> modes, while still keeping the original O_NDELAY bug fixed.
>
> Cc: stable@...r.kernel.org # v4.5+
> Reported-by: Wim Osterholt <wim@....tudelft.nl>
> Tested-by: Wim Osterholt <wim@....tudelft.nl>
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Added for this series, thanks.

-- 
Jens Axboe