linux-kernel - Re: [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160726072729.GB29844@pali>
Date:	Tue, 26 Jul 2016 09:27:29 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	"Andrew F . Davis" <afd@...com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Andrzej Hajda <a.hajda@...sung.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	letux-kernel@...nphoenux.org
Subject: Re: [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single

On Monday 18 July 2016 18:12:09 H. Nikolaus Schaller wrote:
> The bq27000 and bq27010 have a single byte FLAGS register.
> Other gauges have 16 bit FLAGS registers.
> 
> For reading the FLAGS register it is sufficient to read the single
> register instead of reading RSOC at the next higher address as
> well and then ignore the high byte.
> 
> This does not change functionality but optimizes i2c and hdq
> traffic.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>

Looks good, add my Acked-by.

-- 
Pali Rohár
pali.rohar@...il.com