linux-kernel - Re: [PATCH v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Ueshp5O438_=MeuCLrCa8axTEx1iXEThyVxCUyg7i33Q@mail.gmail.com>
Date:	Tue, 26 Jul 2016 15:54:22 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

Hi

On Tue, Jul 26, 2016 at 3:34 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> If an i2c access through i2c-cros-ec-tunnel returns an error, the following
> log message is seen on the console.
>
> cros-ec-i2c-tunnel ff200000.spi:ec@0:i2c-tunnel:
>                         Error parsing EC i2c message -121
>
> This can happen a lot if, for example, the i2c-detect command is executed.
>
> Since it is perfectly normal for an i2c controller to report an error,
> drop the message. Also, report -ENXIO instead of -EREMOTEIO if the access
> error is due to NAK from the device, and return -EIO instead of -EREMOTEIO
> for other errors, as suggested in Documentation/i2c/fault-codes.
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v3: Do not assume that unknown status bits reflect an error.
> v2: Drop message entirely instead of replacing it with dev_dbg,
>     and return -EIO instead of -EREMOTEIO for unknown errors.
>
>  drivers/i2c/busses/i2c-cros-ec-tunnel.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index a0d95ff682ae..0e9653852069 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -154,8 +154,10 @@ static int ec_i2c_parse_response(const u8 *buf, struct i2c_msg i2c_msgs[],
>         resp = (const struct ec_response_i2c_passthru *)buf;
>         if (resp->i2c_status & EC_I2C_STATUS_TIMEOUT)
>                 return -ETIMEDOUT;
> +       else if (resp->i2c_status & EC_I2C_STATUS_NAK)
> +               return -ENXIO;
>         else if (resp->i2c_status & EC_I2C_STATUS_ERROR)
> -               return -EREMOTEIO;
> +               return -EIO;
>
>         /* Other side could send us back fewer messages, but not more */
>         if (resp->num_msgs > *num)
> @@ -222,10 +224,8 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
>         }
>
>         result = ec_i2c_parse_response(msg->data, i2c_msgs, &num);
> -       if (result < 0) {
> -               dev_err(dev, "Error parsing EC i2c message %d\n", result);
> +       if (result < 0)
>                 goto exit;
> -       }
>
>         /* Indicate success by saying how many messages were sent */
>         result = num;

Reviewed-by: Douglas Anderson <dianders@...omium.org>