linux-kernel - Re: [v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170128211829.ojuqhllgqjmkgkui@ninjato>
Date:   Sat, 28 Jan 2017 22:18:29 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     dianders@...omium.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

On Tue, Jul 26, 2016 at 03:34:01PM -0700, Guenter Roeck wrote:
> If an i2c access through i2c-cros-ec-tunnel returns an error, the following
> log message is seen on the console.
> 
> cros-ec-i2c-tunnel ff200000.spi:ec@0:i2c-tunnel:
> 			Error parsing EC i2c message -121
> 
> This can happen a lot if, for example, the i2c-detect command is executed.
> 
> Since it is perfectly normal for an i2c controller to report an error,
> drop the message. Also, report -ENXIO instead of -EREMOTEIO if the access
> error is due to NAK from the device, and return -EIO instead of -EREMOTEIO
> for other errors, as suggested in Documentation/i2c/fault-codes.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)