linux-kernel - Re: [PATCH v2] PCI: exynos: refactor exynos pcie driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170128212912.GK20550@bhelgaas-glaptop.roam.corp.google.com>
Date:   Sat, 28 Jan 2017 15:29:12 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Pankaj Dubey <pankaj.dubey@...sung.com>
Cc:     linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
        jingoohan1@...il.com, Niyas Ahmed S T <niyas.ahmed@...sung.com>,
        krzk@...nel.org, jh80.chung@...sung.com, kgene@...nel.org,
        alim.akhtar@...sung.com, bhelgaas@...gle.com, sanath@...sung.com
Subject: Re: [PATCH v2] PCI: exynos: refactor exynos pcie driver

On Thu, Jan 05, 2017 at 09:23:38AM +0530, Pankaj Dubey wrote:
> From: Niyas Ahmed S T <niyas.ahmed@...sung.com>
> 
> Currently Exynos PCIe driver is only supported for Exynos5440 SoC.
> This patch does refactoring of Exynos PCIe driver to extend support
> for other Exynos SoC.
> 
> Following are the main changes done via this patch:
> 
> 1) It adds separate structs for memory, clock resources.
> 
> Reason behind this change is, moving ahead various Exynos SoC will
> have different hardware resources such as iomem, clocks, regmap handles
> etc. for PCIe controller, so keeping these resources in separate struct
> will help us in intiailizing them via per SoC ops, and will avoid too
> many of_machine_is_compatible in code, and help us simplifying
> exynos_pcie struct.
> 
> 2) It add exynos_pcie_ops struct which will allow us to support the
> differences in resources in different Exynos SoC.
> 
> No functional change intended.
> 
> Signed-off-by: Niyas Ahmed S T <niyas.ahmed@...sung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> ---
> This patch set is prepared on top of Krzysztof's for-next and
> PCIe driver cleanup patch [1] by Jaehoon Chung.
> 
> [1]: https://lkml.org/lkml/2016/12/19/44

Jaehoon has posted an updated version since you posted this patch, so
I assume this will need to be rebased on that.  I'll drop this version and
wait for your rebased version.