linux-kernel - Re: [PATCH] cxl: Delete an unnecessary check before the function call "of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <601fb58c-7aee-91ce-2a3d-7a29787968fc@au1.ibm.com>
Date:	Wed, 27 Jul 2016 18:57:07 +1000
From:	Andrew Donnellan <andrew.donnellan@....ibm.com>
To:	Julia Lawall <julia.lawall@...6.fr>,
	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Christophe Lombard <clombard@...ux.vnet.ibm.com>,
	kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Ian Munsie <imunsie@....ibm.com>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] cxl: Delete an unnecessary check before the function call
 "of_node_put"

On 20/07/16 23:38, Julia Lawall wrote:
> I don't think that the call should be there at all.  The loop only exits
> when afu_np is NULL.  Furthermore, the loop should not be written as a for
> loop, but rather with for_each_child_of_node.

Will send a patch to fix both issues shortly.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited