linux-kernel - Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160728081143.GD8609@e106497-lin.cambridge.arm.com>
Date:	Thu, 28 Jul 2016 09:11:43 +0100
From:	Liviu Dudau <liviu.dudau@....com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	Brian Starkey <brian.starkey@....com>,
	Mali DP Maintainers <malidp@...s.arm.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in
 malidp_bind()

On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the DRM_ERROR call to avoid redundant
> error message.

Yeah, good catch!

> 
> Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>

Acked-by: Liviu Dudau <Liviu.Dudau@....com>


Thanks for the cleanup!
Liviu

> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 4e61ea5..1160322 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	hwdev->regs = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(hwdev->regs)) {
> -		DRM_ERROR("Failed to map control registers area\n");
> +	if (IS_ERR(hwdev->regs))
>  		return PTR_ERR(hwdev->regs);
> -	}
>  
>  	hwdev->pclk = devm_clk_get(dev, "pclk");
>  	if (IS_ERR(hwdev->pclk))
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯