linux-kernel - Re: [PATCH] Input - elantech: fix debug dump of the current packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160728182228.GC16852@dtor-ws>
Date:	Thu, 28 Jul 2016 11:22:28 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input - elantech: fix debug dump of the current packet

On Thu, Jul 28, 2016 at 11:58:55AM +0200, Benjamin Tissoires wrote:
> The use of mixed psmouse_printk() and printk creates 2 lines in the log,
> while the use of %*ph solves everything.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Applied, thank you.

> ---
>  drivers/input/mouse/elantech.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 615d23e..3461d04 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -222,12 +222,8 @@ static int elantech_write_reg(struct psmouse *psmouse, unsigned char reg,
>   */
>  static void elantech_packet_dump(struct psmouse *psmouse)
>  {
> -	int	i;
> -
> -	psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [");
> -	for (i = 0; i < psmouse->pktsize; i++)
> -		printk("%s0x%02x ", i ? ", " : " ", psmouse->packet[i]);
> -	printk("]\n");
> +	psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [%*ph]",
> +		       psmouse->pktsize, psmouse->packet);
>  }
>  
>  /*
> -- 
> 2.5.5
> 

-- 
Dmitry