linux-kernel - Re: [PATCH v1 0/3] Fix seccomp for UM (next)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+CODSZa9bZGda2ovwB62y9TkQD8Wqh9KvMrE=SoJxZjg@mail.gmail.com>
Date:	Thu, 28 Jul 2016 11:29:45 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Mickaël Salaün <mic@...ikod.net>,
	James Morris <jmorris@...ei.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jeff Dike <jdike@...toit.com>,
	Richard Weinberger <richard@....at>,
	Olof Johansson <olof@...om.net>,
	user-mode-linux-devel@...ts.sourceforge.net,
	linux-security-module <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v1 0/3] Fix seccomp for UM (next)

On Mon, Jul 11, 2016 at 6:59 PM, Kees Cook <keescook@...omium.org> wrote:
> On Mon, Jul 11, 2016 at 5:56 PM, Mickaël Salaün <mic@...ikod.net> wrote:
>> Hi,
>>
>> This series fix the recent seccomp update for the User-mode Linux architecture
>> (32-bit and 64-bit) since commit 26703c636c1f3272b39bd0f6d04d2e970984f1b6
>> (close the hole where ptrace can change a syscall out from under seccomp).
>>
>> Regards,
>>
>> Mickaël Salaün (3):
>>   um/ptrace: Fix the syscall_trace_leave call
>>   um/ptrace: Fix the syscall number update after a ptrace
>>   seccomp: Remove 2-phase API documentation
>>
>>  arch/Kconfig                  | 11 -----------
>>  arch/um/kernel/skas/syscall.c | 10 +++-------
>>  arch/x86/um/ptrace_32.c       |  3 +++
>>  arch/x86/um/ptrace_64.c       |  4 ++++
>>  4 files changed, 10 insertions(+), 18 deletions(-)
>
> Ah, perfect! Thanks for fixing this! James, can you pick this up for -next?
>
> Acked-by: Kees Cook <keescook@...omium.org>

James, can you take these fixes for v4.8? We'll need them for um to
work correctly again. (They appear to still be missing from -next.)

Thanks!

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security