linux-kernel - Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160801132703.GF13544@dhcp22.suse.cz>
Date:	Mon, 1 Aug 2016 15:27:04 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Vladimir Davydov <vdavydov@...tuozzo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Hillf Danton <hillf.zj@...baba-inc.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Minchan Kim <minchan@...nel.org>,
	Rik van Riel <riel@...riel.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on
 global reclaim

On Mon 01-08-16 16:21:45, Vladimir Davydov wrote:
> On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote:
> > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote:
> > > We must call shrink_slab() for each memory cgroup on both global and
> > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally
> > > changed that so that now shrink_slab() is only called with memcg != NULL
> > > on memcg reclaim. As a result, memcg-aware shrinkers (including
> > > dentry/inode) are never invoked on global reclaim. Fix that.
> > > 
> > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis")
> > 
> > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere.
> 
> I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's
> d71df22b55099.

But this sha is unstable. THe patch you are referring to is already
sitting in the Linus tree so please use his (stable sha instead).
-- 
Michal Hocko
SUSE Labs