linux-kernel - Re: Fixup direct bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36734f69-33f5-c2fd-67da-d2d867741403@kernel.dk>
Date:	Mon, 1 Aug 2016 09:17:50 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@...radead.org>,
	Shaun Tancheff <shaun@...cheff.com>
Cc:	linux-block@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...com>,
	Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
	David Sterba <dsterba@...e.com>,
	Mike Christie <mchristi@...hat.com>
Subject: Re: Fixup direct bi_rw modifiers

On 08/01/2016 05:47 AM, Christoph Hellwig wrote:
> On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote:
>> bi_rw should be using bio_set_op_attrs to set bi_rw.
>
> Looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@....de>

Added, thanks Shaun.

> Jens,
>
> what do you think about renaming bi_rw?  There aren't too many users
> left, and any old code that would keep using it is alsmost guranteed
> to be broken, so sending a post-rc1 patch to rename it might make
> everyone else life easier.  Especially as it's also grossly misnamed
> now.

I was planning on doing that, after -rc1. Much better to get build
breakage, than potentially much worse breakage.

-- 
Jens Axboe