linux-kernel - Re: [PATCH v2 2/3] powerpc: Call chained reset handlers during reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160801134734.05eaedd1@roar.ozlabs.ibm.com>
Date:	Mon, 1 Aug 2016 13:47:34 +1000
From:	Nicholas Piggin <npiggin@...il.com>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Scott Wood <oss@...error.net>,
	Alessio Igor Bogani <alessio.bogani@...ttra.eu>,
	Paul Mackerras <paulus@...ba.org>,
	Daniel Axtens <dja@...ens.net>
Subject: Re: [PATCH v2 2/3] powerpc: Call chained reset handlers during
 reset

On Thu, 28 Jul 2016 16:07:17 -0700
Andrey Smirnov <andrew.smirnov@...il.com> wrote:

> Call out to all restart handlers that were added via
> register_restart_handler() API when restarting the machine.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> ---
> 
> No changes compared to v1
> 
>  arch/powerpc/kernel/setup-common.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/powerpc/kernel/setup-common.c
> b/arch/powerpc/kernel/setup-common.c index 5cd3283..205d073 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -145,6 +145,10 @@ void machine_restart(char *cmd)
>  		ppc_md.restart(cmd);
>  
>  	smp_send_stop();
> +
> +	do_kernel_restart(cmd);
> +	mdelay(1000);
> +
>  	machine_hang();
>  }
>  

Ah, I see why you don't move smp_send_stop(). 3 other architectures
call do_kernel_restart(). arm and arm64 call it with
local_irq_disabled(). arm and mips insert the 1s delay. All call it
after smp_send_stop(). I don't see the harm in the delay. Should we
call it with local interrupts disabled?