linux-kernel - Re: [PATCH v2 3/3] powerpc: Convert fsl_rstcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160801140351.49119867@roar.ozlabs.ibm.com>
Date:	Mon, 1 Aug 2016 14:03:51 +1000
From:	Nicholas Piggin <npiggin@...il.com>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Scott Wood <oss@...error.net>,
	Alessio Igor Bogani <alessio.bogani@...ttra.eu>,
	Paul Mackerras <paulus@...ba.org>,
	Daniel Axtens <dja@...ens.net>
Subject: Re: [PATCH v2 3/3] powerpc: Convert fsl_rstcr_restart to a reset
 handler

On Thu, 28 Jul 2016 16:07:18 -0700
Andrey Smirnov <andrew.smirnov@...il.com> wrote:

> Convert fsl_rstcr_restart into a function to be registered with
> register_reset_handler().
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> ---
> 
> Changes since v1:
> 
> 	- fsl_rstcr_restart is registered as a reset handler in
>           setup_rstcr, replacing per-board arch_initcall approach

Bear in mind I don't know much about the embedded or platform code!

The documentation for reset notifiers says that they are expected
to be registered from drivers, not arch code. That seems to only be
intended to mean that the standard ISA or platform reset would
normally be handled directly by the arch, whereas if you have an
arch specific driver for a reset hardware that just happens to live
under arch/, then fsl_rstcr_restart / mpc85xx_cds_restart would be
valid use of reset notifier.

So this change seems reasonable to me. One small question:

> +static int mpc85xx_cds_restart_register(void)
> +{
> +	static struct notifier_block restart_handler;
> +
> +	restart_handler.notifier_call = mpc85xx_cds_restart;
> +	restart_handler.priority = 192;

Should there be a header with #define's for these priorities?

Thanks,
Nick