linux-kernel - [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160801233610.10479-1-khilman@baylibre.com>
Date:	Mon,  1 Aug 2016 16:36:08 -0700
From:	Kevin Hilman <khilman@...libre.com>
To:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Cc:	alsa-devel@...a-project.org, Sekhar Nori <nsekhar@...com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue

An ASoC driver using simple-card, when built as a module gets the
following error at module load time:

[   23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
[   23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)

fix this by including simple-card-utils.o symbols in the module build
its symols are resolved correctly.

Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp,
with all of ASoC built as modules.

Cc: Sekhar Nori <nsekhar@...com>
Signed-off-by: Kevin Hilman <khilman@...libre.com>
---
 sound/soc/generic/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile
index 45602ca8536e..ff0c55eee4f7 100644
--- a/sound/soc/generic/Makefile
+++ b/sound/soc/generic/Makefile
@@ -2,4 +2,8 @@ obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o
 
 snd-soc-simple-card-objs	:= simple-card.o
 
+ifneq ($(CONFIG_SND_SIMPLE_CARD_UTILS),)
+snd-soc-simple-card-objs	+=  simple-card-utils.o
+endif
+
 obj-$(CONFIG_SND_SIMPLE_CARD)	+= snd-soc-simple-card.o
-- 
2.9.0