linux-kernel - Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com>
Date:	Tue, 2 Aug 2016 01:13:40 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Kevin Hilman <khilman@...libre.com>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, <alsa-devel@...a-project.org>,
	Sekhar Nori <nsekhar@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue

Hi Kevin

Thank you for your patch

> An ASoC driver using simple-card, when built as a module gets the
> following error at module load time:
> 
> [   23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
> [   23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)
> 
> fix this by including simple-card-utils.o symbols in the module build
> its symols are resolved correctly.
> 
> Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp,
> with all of ASoC built as modules.
> 
> Cc: Sekhar Nori <nsekhar@...com>
> Signed-off-by: Kevin Hilman <khilman@...libre.com>
> ---

Hmm... strange...

simple-card-utils will be used not only simple-card in the future,
thus it should be build separately.

And, snd_soc_of_parse_daifmt() and snd_soc_of_parse_card_name() are
already exported on soc-core.c ?

I tried it as module, but no error for me

...
  CHK     kernel/config_data.h
  LD      sound/soc/generic/built-in.o
  CC [M]  sound/soc/generic/simple-card-utils.o
  CC [M]  sound/soc/generic/simple-card.o
  LD [M]  sound/soc/generic/snd-soc-simple-card.o
  LD      sound/soc/built-in.o
  LD      sound/built-in.o
...
  MODPOST 7 modules
  Kernel: arch/arm/boot/Image is ready
  Kernel: arch/arm/boot/Image is ready
  CC      sound/soc/generic/simple-card-utils.mod.o
  CC      sound/soc/generic/snd-soc-simple-card.mod.o
  GZIP    arch/arm/boot/compressed/piggy_data
  LD [M]  sound/soc/generic/simple-card-utils.ko
  LD [M]  sound/soc/generic/snd-soc-simple-card.ko
  AS      arch/arm/boot/compressed/piggy.o
  LD      arch/arm/boot/compressed/vmlinux
  OBJCOPY arch/arm/boot/zImage
  Kernel: arch/arm/boot/zImage is ready

Best regards
---
Kuninori Morimoto