linux-kernel - Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <189828785.7811267.1470142610748.JavaMail.zimbra@redhat.com>
Date:	Tue, 2 Aug 2016 08:56:50 -0400 (EDT)
From:	Laurence Oberman <loberman@...hat.com>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	don brace <don.brace@...rosemi.com>,
	len brown <len.brown@...el.com>, pavel@....cz,
	gregkh@...uxfoundation.org, hpa@...or.com, x86@...nel.org,
	iss storagedev <iss_storagedev@...com>,
	esc storagedev <esc.storagedev@...rosemi.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng liu <chuansheng.liu@...el.com>
Subject: Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with
 macro



----- Original Message -----
> From: "Baole Ni" <baolex.ni@...el.com>
> To: "don brace" <don.brace@...rosemi.com>, "len brown" <len.brown@...el.com>, pavel@....cz,
> gregkh@...uxfoundation.org, hpa@...or.com, x86@...nel.org
> Cc: "iss storagedev" <iss_storagedev@...com>, "esc storagedev" <esc.storagedev@...rosemi.com>,
> linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, "chuansheng liu" <chuansheng.liu@...el.com>, "baolex ni"
> <baolex.ni@...el.com>
> Sent: Tuesday, August 2, 2016 6:39:14 AM
> Subject: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro
> 
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/block/cciss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 63c2064..05dc1bd 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -67,7 +67,7 @@ MODULE_SUPPORTED_DEVICE("HP Smart Array Controllers");
>  MODULE_VERSION("3.6.26");
>  MODULE_LICENSE("GPL");
>  static int cciss_tape_cmds = 6;
> -module_param(cciss_tape_cmds, int, 0644);
> +module_param(cciss_tape_cmds, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(cciss_tape_cmds,
>  	"number of commands to allocate for tape devices (default: 6)");
>  static int cciss_simple_mode;
> --
> 2.9.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Looks fine: 
Reviewed by: Laurence Oberman <loberman@...hat.com>