linux-kernel - Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1470148969.2485.20.camel@HansenPartnership.com>
Date:	Tue, 02 Aug 2016 10:42:49 -0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Baole Ni <baolex.ni@...el.com>, don.brace@...rosemi.com,
	len.brown@...el.com, pavel@....cz, gregkh@...uxfoundation.org,
	hpa@...or.com, x86@...nel.org
Cc:	iss_storagedev@...com, esc.storagedev@...rosemi.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com
Subject: Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

On Tue, 2016-08-02 at 18:39 +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access 
> permission. As we know, these numeric value for access permission 
> have had the corresponding macro, and that using macro can improve 
> the robustness and readability of the code, thus, I suggest replacing
> the numeric parameter with the macro.

Please stop ... can't you see that sending out over a thousand emails
with a single change in each is basically spam, especially for those of
us who got our INBOXes filled by virtue of being on the direct cc.  You
don't need the thousand emails to achieve agreement over whether we
should do this, and if we decide to do it, Linus would far rather run a
simple script over the kernel as it is in an -rc state.  Could you
please begin a discussion by posting the suggestion and the script.

Thanks,

James