linux-kernel - [PATCH 0418/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160802110948.9679-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 19:09:48 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	mchehab@...nel.org, maurochehab@...il.com, mchehab@...radead.org,
	mchehab@...hat.com, m.chehab@...sung.com,
	kyungmin.park@...sung.com, a.hajda@...sung.com, bp@...en8.de
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com,
	akpm@...ux-foundation.org, g.liakhovetski@....de
Subject: [PATCH 0418/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/media/i2c/s5c73m3/s5c73m3-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
index 08af58f..ec9cf9aa 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
@@ -40,13 +40,13 @@
 #include "s5c73m3.h"
 
 int s5c73m3_dbg;
-module_param_named(debug, s5c73m3_dbg, int, 0644);
+module_param_named(debug, s5c73m3_dbg, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 static int boot_from_rom = 1;
-module_param(boot_from_rom, int, 0644);
+module_param(boot_from_rom, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 static int update_fw;
-module_param(update_fw, int, 0644);
+module_param(update_fw, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 #define S5C73M3_EMBEDDED_DATA_MAXLEN	SZ_4K
 #define S5C73M3_MIPI_DATA_LANES		4
-- 
2.9.2