linux-kernel - Re: [PATCH] ASoC: simple-card-utils: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2r3a7qa2f.fsf@baylibre.com>
Date:	Tue, 02 Aug 2016 11:50:48 -0700
From:	Kevin Hilman <khilman@...libre.com>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, <alsa-devel@...a-project.org>,
	Sekhar Nori <nsekhar@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()

Kuninori Morimoto <kuninori.morimoto.gx@...esas.com> writes:

> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>
> simple-card-utils might be used as module, but MODULE_xxx()
> information was missed. This patch adds it.
> Otherwise, we will have below error, and can't use it.
> Specil thanks to Kevin.
>
>> insmod simple-card-utils.ko
> simple_card_utils: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint
> simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
> simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)
> insmod: can't insert 'simple-card-utils.ko': \
>         unknown symbol in module, or unknown parameter
>
> Reported-by: Kevin Hilman <khilman@...libre.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> ---
>
>>> Kevin
>
> Thank you for your report. I think this patch can solve your issue.
> Can you check this ?

Your patch works, but as Mark pointed out, I didn't think that this was
the right fix as this isn't a module, but just library.

Kevin