linux-kernel - Re: [PATCH] ASoC: simple-card-utils: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160802194146.GI10376@sirena.org.uk>
Date:	Tue, 2 Aug 2016 20:41:46 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kevin Hilman <khilman@...libre.com>
Cc:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	alsa-devel@...a-project.org, Sekhar Nori <nsekhar@...com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()

On Tue, Aug 02, 2016 at 11:50:48AM -0700, Kevin Hilman wrote:

> Your patch works, but as Mark pointed out, I didn't think that this was
> the right fix as this isn't a module, but just library.

I think building the library as a module is fine, that way we can load
it only in situations where it's used, it's just that it should be
pulled in by the relevant driver.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)