linux-kernel - Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160802185447.GA5288@localhost>
Date:	Tue, 2 Aug 2016 11:54:47 -0700
From:	Olof Johansson <olof@...om.net>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	mchehab@...nel.org, maurochehab@...il.com, mchehab@...radead.org,
	mchehab@...hat.com, m.chehab@...sung.com, egor@...emi.com,
	dougthompson@...ssion.com, bp@...en8.de,
	linuxppc-dev@...ts.ozlabs.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, chuansheng.liu@...el.com,
	lee.jones@...aro.org
Subject: Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 06:45:15PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

Am I the only one who find the readability to be MUCH better for the
numeric values?


-Olof