linux-kernel - Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802191130.GG9387@gate.crashing.org>
Date:	Tue, 2 Aug 2016 14:11:30 -0500
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Olof Johansson <olof@...om.net>
Cc:	Baole Ni <baolex.ni@...el.com>, chuansheng.liu@...el.com,
	maurochehab@...il.com, mchehab@...hat.com,
	linux-edac@...r.kernel.org, lee.jones@...aro.org,
	linux-kernel@...r.kernel.org, mchehab@...radead.org,
	egor@...emi.com, dougthompson@...ssion.com, bp@...en8.de,
	mchehab@...nel.org, linuxppc-dev@...ts.ozlabs.org,
	m.chehab@...sung.com
Subject: Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 11:54:47AM -0700, Olof Johansson wrote:
> On Tue, Aug 02, 2016 at 06:45:15PM +0800, Baole Ni wrote:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> 
> Am I the only one who find the readability to be MUCH better for the
> numeric values?

You are not the only one.  Robustness is a non-issue here as well (except
that this patch series showed that some mail servers struggle to handle
1285 emails).


Segher