[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20160802111330.12145-1-baolex.ni@intel.com>
Date: Tue, 2 Aug 2016 19:13:30 +0800
From: Baole Ni <baolex.ni@...el.com>
To: mchehab@...nel.org, maurochehab@...il.com, mchehab@...radead.org,
mchehab@...hat.com, m.chehab@...sung.com, awalls@...metrocast.net,
a.hajda@...sung.com, bp@...en8.de
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
chuansheng.liu@...el.com, baolex.ni@...el.com,
elfring@...rs.sourceforge.net
Subject: [PATCH 0454/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
drivers/media/pci/cx18/cx18-alsa-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx18/cx18-alsa-pcm.c b/drivers/media/pci/cx18/cx18-alsa-pcm.c
index ffb6acd..7bbe3da 100644
--- a/drivers/media/pci/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/pci/cx18/cx18-alsa-pcm.c
@@ -40,7 +40,7 @@
#include "cx18-alsa-pcm.h"
static unsigned int pcm_debug;
-module_param(pcm_debug, int, 0644);
+module_param(pcm_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(pcm_debug, "enable debug messages for pcm");
#define dprintk(fmt, arg...) do { \
--
2.9.2
Powered by blists - more mailing lists